Re: [PATCH 1/2] d3d11: Partially implement d3d11_immediate_context_CopySubresourceRegion1().

[Józef Kucia]

On Wed, May 16, 2018 at 11:30 AM, Pablo Martin  wrote:
> Forwards calls to CopySubresourceRegion ignoring copy flags.
> Signed-off-by: Pablo Martin
>
> Some remarks:
> - I changed argument names for consistency with d3d11_immediate_CopySubresourceRegion.
> - I believe inverse forwarding would be better (CopySubresourceRegion to CopySubresourceRegion1), but I'm initially implementing like this for consistency with UpdateSubresource1. I can invert this and UpdateSubresource1 in a further patch if this is desired.
> - I'm also not sure about the benefit in the double trace here, but again, doing it like UpdateSubresource1 is doing.

Yes, the inverse forwarding could be better, but the the best option
might be to simply add the "flags" parameter to
wined3d_device_copy_sub_resource_region() and call
wined3d_device_copy_sub_resource_region() directly from
UpdateSubresource() and UpdateSubresource1().