Re: [PATCH 4/5] msi: Handle the remote case in MsiSummaryInfoGetProperty.

[Zebediah Figura]

On 08/29/2018 05:07 AM, Dmitry Timoshkov wrote:
> Nikolay Sivov  wrote:
> > On 08/29/2018 12:28 PM, Dmitry Timoshkov wrote:
> > > -
> > >        /* FIXME: should use SEH */
> > > -
> > >        if (!puiDataType || !piValue || !pftValue || !szValueBuf || !pcchValueBuf)
> > > -
> > >            return RPC_X_NULL_REF_POINTER;
> >
> > This means it belongs to the server.
>
> $ grep "FIXME: should use SEH" dlls/msi/*
> install.c:        /* FIXME: should use SEH */
> install.c:        /* FIXME: should use SEH */
> install.c:        /* FIXME: should use SEH */
> suminfo.c:            /* FIXME: should use SEH */
> suminfo.c:            /* FIXME: should use SEH */
> suminfo.c:            /* FIXME: should use SEH */

Right. I just handled it this way since it seemed simpler than setting 
up a SEH frame, even though that's fairly obviously how it's done on 
Windows.