On 4/23/21 3:40 PM, Alexandre Julliard wrote:
Rémi Bernon rbernon@codeweavers.com writes:
Signed-off-by: Rémi Bernon rbernon@codeweavers.com
dlls/user32/driver.c | 79 +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 78 insertions(+), 1 deletion(-)
It should be moved instead of copied, but even better, that sort of thing should be done in the generic code, to make fallbacks available to all drivers.
The goal shouldn't be to add a lot of code to the null driver, because that would mean that a lot of code is needed in all drivers. On the contrary, ideally the null driver would remain empty, and the user32 code would provide the necessary functionality, while letting the drivers override only the parts that need special handling.
I can only agree. It's however sometimes a bit hard to tell what was a driver specific behavior from what wasn't.
For instance, I don't know if the Android keyboard implementation is only implementing a simple en-US keyboard or if it has something specific that need to be kept.
I guess that answers it and I'll move the code instead.