Jacek Caban jacek@codeweavers.com wrote:
+static HRESULT read_stream(BSCallback *This, IStream *stream, void *buf, DWORD size, DWORD *ret_size) +{
- DWORD read_size = 0;
- HRESULT hres;
- hres = IStream_Read(stream, buf, size, &read_size);
- This->readed += (*ret_size = read_size);
- return hres;
+}
Using 'ret_size' directly in the IStream_Read call would look more natural IMHO, like: hres = IStream_Read(stream, buf, size, ret_size); This->readed += *ret_size;