[PATCH v2 5/6] ntoskrnl.exe/tests: Add some HidD_SetFeature tests.

[Rémi Bernon]

Signed-off-by: Rémi Bernon 
---
 dlls/ntoskrnl.exe/tests/driver_hid.c | 19 +++++++++++
 dlls/ntoskrnl.exe/tests/ntoskrnl.c   | 49 ++++++++++++++++++++++++++++
 2 files changed, 68 insertions(+)

diff --git a/dlls/ntoskrnl.exe/tests/driver_hid.c b/dlls/ntoskrnl.exe/tests/driver_hid.c
index ae039c061de..7c85e9a67db 100644
--- a/dlls/ntoskrnl.exe/tests/driver_hid.c
+++ b/dlls/ntoskrnl.exe/tests/driver_hid.c
@@ -424,6 +424,25 @@ static NTSTATUS WINAPI driver_internal_ioctl(DEVICE_OBJECT *device, IRP *irp)
             break;
         }

+        case IOCTL_HID_SET_FEATURE:
+        {
+            HID_XFER_PACKET *packet = irp->UserBuffer;
+            ULONG expected_size = 17;
+            todo_wine ok(in_size == sizeof(*packet), "got input size %u\n", in_size);
+            todo_wine ok(!out_size, "got output size %u\n", out_size);
+
+            todo_wine_if(packet->reportId != report_id)
+            ok(packet->reportId == report_id, "got packet report id %u\n", packet->reportId);
+            todo_wine_if(packet->reportBufferLen == 0 || packet->reportBufferLen == 16)
+            ok(packet->reportBufferLen >= expected_size, "got packet buffer len %u, expected %d or more\n",
+               packet->reportBufferLen, expected_size);
+            ok(!!packet->reportBuffer, "got packet buffer %p\n", packet->reportBuffer);
+
+            irp->IoStatus.Information = 3;
+            ret = STATUS_SUCCESS;
+            break;
+        }
+
         case IOCTL_HID_GET_STRING:
             ok(!in_size, "got input size %u\n", in_size);
             ok(out_size == 128, "got output size %u\n", out_size);
diff --git a/dlls/ntoskrnl.exe/tests/ntoskrnl.c b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
index 8539e2ee921..af30829da99 100644
--- a/dlls/ntoskrnl.exe/tests/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
@@ -2531,6 +2531,55 @@ static void test_hidp(HANDLE file, int report_id)
     ok(report[0] == report_id, "got report[0] %02x, expected %02x\n", report[0], report_id);

+    memset(report, 0xcd, sizeof(report));
+    status = HidP_InitializeReportForID(HidP_Feature, report_id, preparsed_data, report, caps.FeatureReportByteLength);
+    ok(status == HIDP_STATUS_SUCCESS, "HidP_InitializeReportForID returned %#x\n", status);
+
+    SetLastError(0xdeadbeef);
+    ret = HidD_SetFeature(file, report, 0);
+    todo_wine ok(!ret, "HidD_SetFeature succeeded\n");
+    todo_wine ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "HidD_SetFeature returned error %u\n", GetLastError());
+
+    SetLastError(0xdeadbeef);
+    ret = HidD_SetFeature(file, report, caps.FeatureReportByteLength - 1);
+    todo_wine
+    ok(!ret, "HidD_SetFeature succeeded\n");
+    todo_wine
+    ok(GetLastError() == ERROR_INVALID_PARAMETER || broken(GetLastError() == ERROR_CRC),
+       "HidD_SetFeature returned error %u\n", GetLastError());
+
+    SetLastError(0xdeadbeef);
+    memset(buffer, 0x5a, sizeof(buffer));
+    ret = HidD_SetFeature(file, buffer, caps.FeatureReportByteLength);
+    if (report_id || broken(!ret))
+    {
+        todo_wine
+        ok(!ret, "HidD_SetFeature succeeded, last error %u\n", GetLastError());
+        todo_wine
+        ok(GetLastError() == ERROR_INVALID_PARAMETER || broken(GetLastError() == ERROR_CRC),
+           "HidD_SetFeature returned error %u\n", GetLastError());
+    }
+    else
+    {
+        ok(ret, "HidD_SetFeature failed, last error %u\n", GetLastError());
+    }
+
+    SetLastError(0xdeadbeef);
+    ret = HidD_SetFeature(file, report, caps.FeatureReportByteLength);
+    ok(ret, "HidD_SetFeature failed, last error %u\n", GetLastError());
+
+    value = caps.FeatureReportByteLength * 2;
+    SetLastError(0xdeadbeef);
+    ret = sync_ioctl(file, IOCTL_HID_SET_FEATURE, NULL, 0, report, &value);
+    todo_wine ok(!ret, "IOCTL_HID_SET_FEATURE succeeded\n");
+    todo_wine ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "IOCTL_HID_SET_FEATURE returned error %u\n", GetLastError());
+    value = 0;
+    SetLastError(0xdeadbeef);
+    ret = sync_ioctl(file, IOCTL_HID_SET_FEATURE, report, caps.FeatureReportByteLength * 2, NULL, &value);
+    ok(ret, "IOCTL_HID_SET_FEATURE failed, last error %u\n", GetLastError());
+    todo_wine ok(value == 3, "got length %u, expected 3\n", value);
+
+
     HidD_FreePreparsedData(preparsed_data);
     CloseHandle(file);
 }