On 6/7/19 2:53 PM, Huw Davies wrote:
On Fri, Jun 07, 2019 at 02:22:14PM +0300, Gabriel Ivăncescu wrote:
Hi Huw,
On 6/7/19 12:47 PM, Huw Davies wrote:
On Fri, May 24, 2019 at 03:09:34PM +0300, Gabriel Ivăncescu wrote:
I'm not sure we need to define these ourselves, we can just pull them from the headers. I realise that you're copying what was done with VFAT_IOCTL_READDIR_BOTH and I don't know why that was done that way, but unless there's a reason to do this, let's not add more.
EXT2_IOC_GETFLAGS seems to be defined in linux/ext2_fs.h. The problem is that I don't seem to have that header neither on my machine or build environments. I'm guessing it's part of some different dependency. (of course, I can use the ioctl manually if I define it myself)
It's probably the reason VFAT_IOCTL_READDIR_BOTH was defined like that as well, I'm guessing most people or distros don't have these headers with just Wine's dependencies.
Should I still import it from header or leave it as is?
Ah right, the kernel doesn't export them. They are in ext2fs/ext2_fs.h (from e2fslibs-dev on Ubuntu) which doesn't seem like too much of a burden.
Just to be clear, you want me to include this header, right? And add a configure check for it?