On 08.09.2017 19:06, Alex Henrie wrote:
2017-09-08 9:53 GMT-06:00 Nikolay Sivov bunglehead@gmail.com:
On 08.09.2017 18:28, Alex Henrie wrote:
Nikolay,
Thanks for the feedback. Before I dig into the shell32 code further, do you have any more thoughts about my msxml3 patch that has been sitting in the queue? I'd prefer to not be working on two DLLs at the same time with the same person.
I'm worried it could unexpectedly break more than it fixes. It's already fragile regarding whitespace normalization.
For example I see you still have todo for msxml6 case, where output differs. It might seem unimportant but unfortunately it is some applications (and servers) are picky about document structure. Do you think it's possible to fix that too?
That todo is for a completely different bug. It was broken before my patch, and it's broken a little less after my patch.
Ok.
Newline normalization is mandated by section 2.11 of the XML specification, so it should not come as a surprise to anyone: https://www.w3.org/TR/REC-xml/#sec-line-ends
If the only problem with the patch is a vague uneasiness about it, maybe you could agree to accept it if Wine Staging takes the patch and no bugs are reported within a couple of months.
I have no problem with that option.
-Alex