On 15 November 2011 23:23, Stefan Dösinger stefandoesinger@gmx.at wrote:
On Tuesday 15 November 2011 20:53:43 Henri Verbeet wrote:
It's probably ok to ignore the more obscure cases of getting an earlier interface through QI on a newer interface, but I think we should at least test version differences for interfaces originally created with a particular version.
Keep in mind that IDirectDrawSurface is created by IDirectDraw and IDirectDraw2. IDirectDrawSurface2 and IDirectDrawSurface3 are only available via QueryInterface.
Yes, but that's ok because a "normal" application written when those were the current versions of the interfaces would get those like that as well.
Even with just one test copy per IDirectDraw*X interface it'll probably triple the size of overlay.c, ddrawmodes.c and dsurface.c by creating essentially copypasted versions of all tests(excluding those that exist in higher interfaces only).
I don't think that's necessarily a bad thing.