On Mon, Oct 20, 2008 at 12:19 PM, Alexandre Julliard julliard@winehq.org wrote:
"James Hawkins" jhawkins@codeweavers.com writes:
The value is quoted in Windows; what's the harm in matching that? The test in question was added to fix an installer (can't remember which one now), and the recently added tests now show that msi is correct, while the current value of the command is incorrect.
The command is supposed to be editable by the user, so we can't depend on a specific format. Also since it's editable it won't be automatically upgraded, so for backwards compatibility we have to handle the current format anyway.
Even if it is editable, I don't see what the problem is with making this the default value. Susan Craig has already run into this problem with the DNS 10 installer, which uses the AppSearch action to search for IE using this value. I don't know the policy of the shell command values, but maybe the executable has to be quoted if options are given.