Re: [PATCH] msado15: Use Recordset_Open in Connection_Execute

[Hans Leidekker]

On Fri, 2021-04-30 at 16:56 +1000, Alistair Leslie-Hughes wrote:
Signed-off-by: Alistair Leslie-Hughes 
---
 dlls/msado15/connection.c | 36 +++++++++++++++++-------------------
 1 file changed, 17 insertions(+), 19 deletions(-)

diff --git a/dlls/msado15/connection.c b/dlls/msado15/connection.c
index a3c9a450be6..2d43aff787f 100644
--- a/dlls/msado15/connection.c
+++ b/dlls/msado15/connection.c
@@ -339,51 +339,49 @@ static HRESULT WINAPI connection_Execute( _Connection *iface, BSTR command, VARI
 {
     struct connection *connection = impl_from_Connection( iface );
     HRESULT hr;
-    ICommandText *command_text;
-    DBROWCOUNT affected;
-    IUnknown *rowset;
     _Recordset *recordset;
-    ADORecordsetConstruction *construct;
+    VARIANT source, active;
+    IDispatch *dispatch;
 
     FIXME( "%p, %s, %p, 0x%08x, %p Semi-stub\n", iface, debugstr_w(command), records_affected, options, record_set );

if (connection->state == adStateClosed) return MAKE_ADO_HRESULT( adErrObjectClosed );

-    hr = create_command_text(connection->session, command, &command_text);

Since you're no longer using create_command_text here, please move the implementation
close to its only user and make it static.