On Sat, Jun 27, 2020 at 9:35 AM Alistair Leslie-Hughes leslie_alistair@hotmail.com wrote:
Hi Vijay,
On 27/6/20 5:14 pm, Vijay Kiran Kamuju wrote:
Hi Alistair
On Sat, 27 Jun 2020, 09:07 Alistair Leslie-Hughes, <leslie_alistair@hotmail.com mailto:leslie_alistair@hotmail.com> wrote:
Hi Vijay, My main concern with this patch is that is missing all other interfaces the the currently staging IDL has (IXACT3SoundBank, IXACT3WaveBank, IXACT3Cue and IXACT3Wave).I was supposed to split the original patch according to the review.
I didn't see any review on the list, so I'm a little confused.
I got an email saying that it 'Needs splitting' - patch# 187862. It's status now on the patches webpage.
I would add the other interfaces when implementing them, they are the next series of patches.
For me, I would add them in reverse order, having the engine patch as the last one. So, IXACT3SoundBank, IXACT3WaveBank, IXACT3Cue, IXACT3Wave then IXACT3Engine. Then when you need to implement the engine, all interfaces are available already. I would ensure that all interfaces are complete in the header before registering anything.
If I remember correctly, you will get an error if the types are incomplete when you try to implement something that uses it. IXACT3Engine references IXACT3SoundBank for example.
Yes, the next patch series is implementing interfaces IXACT3Cue, IXACT3Wave, IXACT3SoundBank, IXACT3WaveBank and at the end IXACT3Engine, in that order. My original patch series consists of 19 patches, for the first 2 patches in staging. So now I have to reorganize and rewrite them.
Alistair.