Re: [PATCH resend] ntdll: Allow renaming a file/directory to a different case of itself.

[Gabriel Ivăncescu]

On 27/07/2021 23:31, Alexandre Julliard wrote:
> Gabriel Ivăncescu  writes:
> > @@ -3426,6 +3426,64 @@ NTSTATUS nt_to_unix_file_name( const OBJECT_ATTRIBUTES *attr, char **name_ret, U
> >   }
> >
> > +/***********************************************************************
> > -
> > -
> >       nt_to_unix_file_name_with_case
> > -
> > -
> > -
> > - Same as nt_to_unix_file_name, but additionally return unix file name
> > -
> > - without path, with the actual case from the NT name's last component.
> > - */
> >
> > +static NTSTATUS nt_to_unix_file_name_with_case( const OBJECT_ATTRIBUTES *attr, char **name_ret,
> > -
> >                                            char **case_ret, UINT disposition )
>
> I still don't see any reason for this to be a wrapper around
> nt_to_unix_file_name(). What it does is unrelated, it should be a
> separate helper function.

Sure, but do you mean just the name? Or what do you want the helper 
function to do specifically?