Hi Jacek,
On 14/02/2011 9:48 PM, Jacek Caban wrote:
On 2/14/11 10:03 AM, Alistair Leslie-Hughes wrote:
Changelog: mshtml: Ignore IActiveScript interface for IXMLHTTPRequest
mshtml?
- else if ( IsEqualGUID( riid,&IID_IActiveScript))
- {
- TRACE("(%p)->(IID_IActiveScript %p) returning NULL\n", This, ppvObject);
- *ppvObject = NULL;
- return E_NOINTERFACE;
- }
else { FIXME("Unsupported interface %s\n", debugstr_guid(riid));
As discussed on wine-devel, please just change the later FIXME to TRACE instead.
By just changing the FIXME to a TRACE would hide this fact that IObjectWithSite and IObjectSafety need to be implemented at some point. Only with msxml tracing would be see this fact, which would lead to hard to pin point errors.
We need to just ignore two know interfaces IActiveScript and IDispatchEx.
If we are going to stop silencing interfaces, Should be just remove the ones already in webbrowser(shdocvw)? No, We do this so other developers can see that these interfaces are not supported and so they don't need to waste there time researching them. We silence interfaces like the above in other places, so why no here?
Best Regards Alistair Leslie-Hughes