2011/2/11 Krzysztof Nikiel knik00@gmail.com
2011/2/11 Dmitry Timoshkov dmitry@codeweavers.com:
Krzysztof Nikiel knik00@gmail.com wrote:
You can't send Makefile changes separately from added/removed files, a patch should not add dead code.
Could you explain "dead code", all 13 parts need to be applied, otherwise the code will be broken.
Wine should compile and be able to pass 'make test' after each separate
patch.
You can't add for instance dlls/dsound/resample.c in one patch, and add
it to
Makefile or use interfaces provided by it in some later patches. Every
patch
should be finished and self-containing.
Well, previous version of this patch was rejected as "needs splitting", it's basically too big to be send as a single patch. It can be applied as several smaller chunks or rejected as a whole. I don't think there is any other option.
still, what dmitry told you still holds. wine needs to be able to compile and pass the tests after each patch is applied. at least the makefile changes should be merged with the previous patches that needs them (1 and 2). the rest seems like fine splitting, although i don't know the code. what i'm not sure is, if resampler is still not called after the first patches, if it is fine to send those first patches... i think you also need to call resampler for the patch to be accepted, even if it is just as a stub, incomplete version.