Re: [PATCH v2] loader: check return values of wld_mprotect and wld_mmap calls

[Sebastian Lackner]

On 22.12.2015 12:22, Paul Gofman wrote:
> Fixes loader crash when compiled using Intel compiler (icc 16.0.1 20151021).
> Signed-off-by: Paul Gofman
>
> loader/preloader.c | 26 +++++++++++++++++---------
>  1 file changed, 17 insertions(+), 9 deletions(-)

Its not my decision, but I don't think its a good idea to add all the (unnecessary) ifs
just to make this code compatible with ICC. I assume the compiler doesn't handle inline
assembly correctly, but this would mean that there are several more affected places.
It would be nice to have a more general solution to fix/workaround this issue.
If this is not possible, I would at least suggest to add a workaround to the functions
directly, instead of adding checks to all places where they are called.