Re: [PATCH] evr: Add stubs for EnhancedVideoRenderer

[Fabian Maurer]

Hi, thanks for your feedback.
> Shouldn't it use strmbase?

You mean the methods that for example quartz/nullrenderer.c uses  in 
NullRenderer_Vtbl?
I'm not sure, that's why I just stubbed them.
> This needs at test for aggregation support.

Sorry I don't know what you mean. Care to elaborate?
> > +typedef struct {
> > - IBaseFilter IBaseFilter_iface;
> > - LONG ref;
> >
> > +} EnhancedVideoRendererImpl;
>
> Does this need to be exposed?

You mean I shouldn't need to put that in a header? I just did it like in 
d3dxof, and it's the same in uiribbon. But yes, I could change that.
> > - TRACE("(0x%p, %d, %p)\n", instance, reason, reserved);
> > -
>
> Format looks wrong.

Already used that in my uiribbon patch and it was fine though. What should I 
change about it?
> It still doesn't do anything.

Yes, I'll re-add that.
> What does XF prefix stand for? Also please use consistent type names and
> formatting.
>
> I personally don't think this export needs a documentation header.
>
> I think it's better to let QueryInterface handle this.

I just copied that code from d3dxof, I figured it was ok since it was accepted 
into my uiribbon patch. Should I change it?
> > - for (i=0; i < sizeof(object_creation)/sizeof(object_creation[0]);
> >
> > i++)
> > - {
> > -
> >    if (IsEqualGUID(object_creation[i].clsid, rclsid))
> > -
> >        break;
> > - }
> > -
> > - if (i == sizeof(object_creation)/sizeof(object_creation[0]))
> > - {
> > -
> >    FIXME("%s: no class found.\n", debugstr_guid(rclsid));
> > -
> >    return CLASS_E_CLASSNOTAVAILABLE;
> > - }
>
> Does it support any other CLSIDs? This seems like too much. Static
> factory instance will work too I suppose.

According to my windows7 registry, yes, there are other CLSIDs in that dll, 
like "MF Video Mixer" and "Tearless Window Presenter" for example.
Not sure what exactly static factory instance means.

Regards,
Fabian Maurer