Re: [PATCH 2/3] msvcp110: Add tr2_sys__Symlink implementation and test.

[Piotr Caban]

On 01/11/16 14:56, YongHao Hu wrote:
> - delete_flag = 1;
> - for(i=0; i<sizeof(tests)/sizeof(tests[0]); i++) {
> -
>    errno = 0xdeadbeef;
> -
>    SetLastError(0xdeadbeef);
> -
>    ret = p_tr2_sys__Symlink(tests[i].existing_path, tests[i].new_path);
> -
>    if(ret==ERROR_PRIVILEGE_NOT_HELD || ret==ERROR_INVALID_FUNCTION) {
> -
>        delete_flag = 0;
> -
>        tests[i].last_error = ret;
> -
>        win_skip("Privilege not held or symbolic link not supported, skipping symbolic link tests.\n");

I think it would be nicer if the tests are really skipped in this case. 
Please detect such case and return from the function instead of adding 
workarounds in the code for it.

Thanks,
Piotr