Re: ntoskrnl.exe: add CmRegisterCallback/CmUnRegisterCallback stub (5/8)

[Sebastian Lackner]

On 09.11.2015 06:59, Austin English wrote:
> +/***********************************************************************
> -
> -
>       CmRegisterCallback  (NTOSKRNL.EXE.@)
> - */
>
> +NTSTATUS CmRegisterCallback(EX_CALLBACK_FUNCTION *function, void *context, LARGE_INTEGER *cookie)

You forgot to specify the calling convention. The function should be declared as WINAPI.
> +{
> - FIXME("(%p %p %p): stub\n", function, context, cookie);
> - return STATUS_NOT_IMPLEMENTED;
>
> +}
> -
>
> +/***********************************************************************
> -
> -
>       CmUnRegisterCallback  (NTOSKRNL.EXE.@)
> - */
>
> +NTSTATUS CmUnRegisterCallback(LARGE_INTEGER cookie)

Same here.
> +{
> - FIXME("%d): stub\n", cookie.u.LowPart);

There is a "(" missing at the beginning of the FIXME. Also, I think it would be useful to print the whole value.
Either something like:

FIXME("(%x%08x): stub\n", cookie.u.HighPart, cookie.u.LowPart);

or use wine_dbgstr_longlong:

FIXME("(%s): stub\n", wine_dbgstr_longlong(cookie.QuadPart));
> - return STATUS_NOT_IMPLEMENTED;
>
> +}