On 09/02/2016 07:17 PM, Andrew Eikum wrote:
I guess I'm not opposed to this, but are these changes useful?
It makes the code consistent aka one way to call the COM methods. There were also forward declarations to use the methods directly but it looks like I have removed those during the COM cleanup.
Anyway with very few exceptions (ddraw, d3d11, ole32, urlmon32) there is just a handful, most of the times just a single, direct method use per dll:
d2d1/geometry.c | 4 +-- d3d11/device.c | 14 ++++++------- ddraw/surface.c | 44 +++++++++++++++++++++---------------------- devenum/mediacatenum.c | 2 - dinput/effect_linuxinput.c | 6 ++--- dmime/performance.c | 2 - dmusic/clock.c | 2 - dmusic/dmusic.c | 2 - dpnet/address.c | 2 - dpnet/client.c | 4 +-- dsound/capture.c | 2 - inetcomm/mimeole.c | 2 - msctf/threadmgr.c | 8 +++---- mshtml/htmlwindow.c | 2 - objsel/objsel.c | 4 +-- ole32/antimoniker.c | 2 - ole32/bindctx.c | 2 - ole32/comcat.c | 2 - ole32/compositemoniker.c | 2 - ole32/datacache.c | 2 - ole32/itemmoniker.c | 2 - ole32/moniker.c | 2 - ole32/pointermoniker.c | 2 - oleaut32/tests/olepicture.c | 2 - oleaut32/tmarshal.c | 2 - oleaut32/typelib.c | 4 +-- quartz/enummoniker.c | 2 - quartz/systemclock.c | 2 - shlwapi/tests/clist.c | 4 +-- urlmon/uri.c | 12 +++++------ windowscodecs/propertybag.c | 2 - winealsa.drv/mmdevdrv.c | 4 +-- winecoreaudio.drv/mmdevdrv.c | 4 +-- wineoss.drv/mmdevdrv.c | 4 +-- winepulse.drv/mmdevdrv.c | 4 +-- 35 files changed, 81 insertions(+), 81 deletions(-)
But of course it is a matter of taste.
bye michael