Re: [PATCH v3 0/6] MR217: windows.media.speech: ISpeechSynthesisStream stub implementation.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/windows.media.speech/synthesizer.c:
> +HRESULT WINAPI synthesis_stream_GetRuntimeClassName( ISpeechSynthesisStream *iface, HSTRING *class_name )
> +{
> - FIXME("iface %p, class_name %p stub.\n", iface, class_name);
> - return E_NOTIMPL;
>
> +}
> -
>
> +HRESULT WINAPI synthesis_stream_GetTrustLevel( ISpeechSynthesisStream *iface, TrustLevel *trust_level )
> +{
> - FIXME("iface %p, trust_level %p stub.\n", iface, trust_level);
> - return E_NOTIMPL;
>
> +}
> -
>
> +HRESULT WINAPI synthesis_stream_get_Markers( ISpeechSynthesisStream *iface, IVectorView_IMediaMarker **value )
> +{
> - FIXME("iface %p, value %p stub!\n", iface, value);
> - *value = NULL;

Shouldn't we return an empty vector view instead? Either create the vector on the fly, or more probably better in the stream constructor and return a view to it here?