On 10/18/16 5:40 PM, Sebastian Lackner wrote:
On 18.10.2016 17:07, Aric Stewart wrote:
Signed-off-by: Aric Stewart aric@codeweavers.com
dlls/hidclass.sys/device.c | 20 +++++++------------- dlls/hidclass.sys/main.c | 13 +++++-------- dlls/hidclass.sys/pnp.c | 10 +++++----- 3 files changed, 17 insertions(+), 26 deletions(-)
Thanks! While you are just at it, could you please also check the two occurances of "if (irp->IoStatus.u.Status == STATUS_PENDING)"? They look wrong to me, the correct way would be to check the return value of IoCallDriver. Also, it looks like call_minidriver is leaking "buffer".
Actually that was intentional at the time. There was code in ntoskrnl that was freeing that buffer already so I was getting a double free issue. Now you have been doing a lot of work there so maybe that has changed. I have not gone back and revisited it.
-aric
Signed-off-by: Sebastian Lackner sebastian@fds-team.de