Re: [PATCH 5/5] wined3d: Add a setting for requesting OpenGL core profile usage.

[Henri Verbeet]

On 19 June 2015 at 00:07, Matteo Bruni  wrote:
> @@ -199,6 +200,14 @@ static BOOL wined3d_dll_init(HINSTANCE hInstDLL)
>  if (hkey || appkey)
>  {
> -
>    if (!get_config_key( hkey, appkey, "UseCore", buffer, size))
> -
>    {
> -
>        if (!strcmp(buffer,"enabled"))
> -
>        {
> -
>            TRACE("Requested OpenGL Core profile.\n");
> -
>            wined3d_settings.use_core = TRUE;
> -
>        }
> -
>    }
>    if ( !get_config_key( hkey, appkey, "UseGLSL", buffer, size) )
>    {
>        if (!strcmp(buffer,"disabled"))

Would it make sense to express this in terms of the maximum (desktop)
GL version to use instead? I imagine that at some point we'll want to
use GL versions beyond 3.2, at which point it may be useful to have
something a bit more flexible than just core/classic.
> @@ -1711,6 +1709,7 @@ struct wined3d_gl_limits
>
> struct wined3d_gl_info
>  {
> - BOOL legacy_gl;
> DWORD glsl_version;
> struct wined3d_gl_limits limits;
> DWORD reserved_glsl_constants, reserved_arb_constants;

This could probably just be an entry in the wined3d_gl_extension enum,
which I suppose might have advantages if we need this information for
building e.g. state or format tables.