2009/5/7 Rein Klazes wijn@online.nl:
On Thu, 7 May 2009 01:54:23 -0500, you wrote:
On Thu, May 7, 2009 at 1:52 AM, Rein Klazes wijn@online.nl wrote:
Fixes bug 10845
Changes from previous patch: menu position calculations moved to nonclient.c.
Can you add a testcase?
I don't see what you would like to test. The menu->Height == zero has the meaning "menusize needs recalculation" all over the code. That you need to have the menu size right before doing a hittest (in MENU_ButtonDown) is even more obvious.
I expect the problem is more the form: touching sensitive nonclient code.
Rein.
Even if it's obvious that this is the right behavior, it's always useful to add a test, at least to prevent regressions.