Re: [PATCH] d3dx9_36: Implement ID3DXSkinInfoImpl_UpdateSkinnedMesh.

[Matteo Bruni]

On Sat, Apr 6, 2019 at 10:50 AM Vijay Kiran Kamuju  wrote:
> This patch fixes last problem of bug 32572.
> https://bugs.winehq.org/show_bug.cgi?id=32572
>
> From: Christian Costa 
> Signed-off-by: Vijay Kiran Kamuju

There are many stylistic and practical issues with this patch which
I'll not get into the details of. I'll point out just one:
> - /* Update positions that are influenced by bones */
> - for (i = 0; i < skin->num_bones; i++) {
> -
>    D3DXMATRIX bone_inverse, matrix;
> -
> -
>    D3DXMatrixInverse(&bone_inverse, NULL, &skin->bones[i].transform);
> -
>    D3DXMatrixMultiply(&matrix, &bone_transforms[i], &bone_inverse);
> -
>    D3DXMatrixMultiply(&matrix, &matrix, &skin->bones[i].transform);

This looks to me like a very expensive way of doing nothing.