Re: [PATCH v2] winex11.drv: Handle Vulkan surface creation with NULL hwnd.

[Zebediah Figura (she/her)]

On 5/1/21 2:21 AM, Rémi Bernon wrote:
> A few style nitpicks, otherwise it looks good to me.
>
> On 4/30/21 4:42 PM, Paul Gofman wrote:
> > @@ -292,8 +297,10 @@ static VkResult X11DRV_vkCreateWin32SurfaceKHR(VkInstance instance,
> >            return VK_ERROR_OUT_OF_HOST_MEMORY;
> >    x11_surface->ref = 1;
> > - x11_surface->hwnd = create_info->hwnd;
> > - x11_surface->window = x11_surface->hwnd ? create_client_window(create_info->hwnd, &default_visual)
> > -
> >        : create_dummy_client_window();
>
> Indentation feels weird here, I think it would be better if ':' was
> aligned with the '?' above.

Personally, if I find myself having to wrap a ternary operator, I take 
it as a sign that I should use an if/else statement instead. Just my two 
cents...