Re: [PATCH 5/5] wined3d: Don't install fog compatibility wrappers in core profile contexts.

[Matteo Bruni]

2015-07-10 13:37 GMT+02:00 Stefan Dösinger :
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 2015-07-10 um 00:06 schrieb Matteo Bruni:
> > - if (!gl_info->supported[EXT_FOG_COORD])
> > - if (!gl_info->supported[EXT_FOG_COORD] && gl_info->supported[WINED3D_GL_LEGACY_CONTEXT])
>
> Shouldn't that depend on the chosen vertex pipeline implementation rather than the context type? I don't think we need those wrappers in legacy contexts if we're using GLSL for vertex processing.

True, we don't need them but it doesn't strictly hurt for the non-core
profile case (with the "hurt" being the GL_ARB_fragment_shader FIXME
inside that 'if', so nothing too terrible really).
I guess I could split add_gl_compat_wrappers() in two and call those
if the selected vertex / fragment pipe advertise e.g. via a caps flag
that they require those extensions.