Re: [PATCH 1/4] ntdll: Increase step after failed map attempt in try_map_free_area().

[Rémi Bernon]

On 2020-07-23 18:32, Paul Gofman wrote:
> Signed-off-by: Paul Gofman
>
> dlls/ntdll/unix/virtual.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/dlls/ntdll/unix/virtual.c b/dlls/ntdll/unix/virtual.c
> index 883e5cff927..7b33b3e82ac 100644
> --- a/dlls/ntdll/unix/virtual.c
> +++ b/dlls/ntdll/unix/virtual.c
> @@ -1033,6 +1033,7 @@ static void* try_map_free_area( void *base, void *end, ptrdiff_t step,
>               step == 0)
>               break;
>           start = (char *)start + step;
> -
>    step *= 2;
> }
>
> return NULL;

Could we use mincore as a better search heuristic, like what was 
suggested before, instead of this which doesn't feel very right?