Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

[Henri Verbeet]

On 26 April 2013 12:41, Jacek Caban  wrote:
> On 04/26/13 12:02, Henri Verbeet wrote:
> > On 26 April 2013 10:27, Jacek Caban  wrote:
> > > - round is not portable. As I mentioned you before, Wine needs to be C89
> > >
> > > compatible. If we need some features that are not part of C89, we need
> > > to be careful about that and it often requires things like configure
> > > checks. In case of round, replacing it with floor(x+0.5) does the trick
> > > pretty well.
> >
> > But that's going to do something different for negative values.
>
> That will be different only for numbers with fractional part equal to
> 0.5, which we have to handle separately using both round and floor anyway.

Yeah, it probably doesn't matter here, you just couldn't use it as a
general replacement in libwine_port.