Re: [PATCH 02/11] wined3d: Add WINED3DSWAPCHAIN_ALLOW_MODE_SWITCH flag.

[Józef Kucia]

On Tue, Aug 2, 2016 at 12:45 PM, Henri Verbeet  wrote:
> On 1 August 2016 at 22:28, Józef Kucia  wrote:
> > -
> >    if (mode)
> > -
> >        ERR("Ignoring mode.\n");
>
> I think it's unclear what this means. "Ignoring mode" seems to suggest
> we're ignoring the mode, but shouldn't, in which case this should be a
> FIXME instead of an ERR. It could also mean the user of the API
> supplied a mode, but it has no effect because
> WINED3DSWAPCHAIN_ALLOW_MODE_SWITCH is not set on the swapchain, in
> which case this should be a WARN instead of an ERR.

Generally, we never call this function with a mode when
WINED3DSWAPCHAIN_ALLOW_MODE_SWITCH is not set. It should be a WARN
anyway.