-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-01-17 um 19:23 schrieb Alex Henrie:
A proper enumeration would take a lot of effort because it changes depending on whether certain DLLs are present, and not all of those DLLs are present in Wine. Also, the strings would have to be localized.
This would probably work by the DLLs registering themselves in the registry and dpvoice enumerating the registry keys. The codecs probably already register themselves.
Most of dpvoice is patent-protected in the United States:
https://www.google.com/patents/US7720908 https://www.google.com/patents/US7730206
GetCompressionTypes is one of the few pieces that we can legally implement.
Fortunately, practically nothing actually uses dpvoice. Star Trek Armada II doesn't even use dpvoice, it's just a dependency of its game engine.
I think under these circumstances adding a semi-stub like yours that makes a game work better is a reasonable thing to do.
Getting rid of the Hungarian notation in DPVOICE_GetCompressionTypes would make it look odd next to the other 3 functions declared in dvoice_private.h. Maybe after these two patches are committed, we could work on another patch to uniformly eliminate the Hungarian notation throughout dpvoice.
Generally style-only changes are discouraged and the right thing to do is to change the style when you're changing the code for other reasons. I personally disagree with that rule since it makes the same style issues pop up again and again and again.