Re: [PATCH 1/2] advapi32/tests: Statically link to ConvertSidToStringSidA()

[Dmitry Timoshkov]

Nikolay Sivov  wrote:
> > > -static BOOL (WINAPI *pConvertSidToStringSidA)( PSID pSid, LPSTR *str );
> > >  static BOOL (WINAPI *pConvertStringSidToSidA)( LPCSTR str, PSID pSid );
> >
> > ...
> > > - pConvertSidToStringSidA = (void *)GetProcAddress(hmod, "ConvertSidToStringSidA");
> > > pConvertStringSidToSidA = (void *)GetProcAddress(hmod, "ConvertStringSidToSidA");
> >
> > ...
> > > - if( !pConvertSidToStringSidA || !pConvertStringSidToSidA )
> > > - if( !pConvertStringSidToSidA )
> >
> > What's so special about ConvertSidToStringSidA and why same logic won't
> > apply to ConvertStringSidToSidA and possibly others?
>
> Who said it's special? One step at a time.

Then why hesitate and not send a 1001-patch sequence right away? That should
be a nice way to improve the patch statistics, and also demostarate to everyone
that the really hard work is constantly in progress.