Andrew Eikum wrote:
This patch was submitted back on Tuesday and I haven't received a response one way or the other about it. Does anyone see anything immediately wrong with it?
I more-or-less copied the functionality of test_GdipDrawBezier right above, testing each of the different input possibilities for correctness. It passes 100% on WinXP SP3 and Win7 RC1, although there are failures in Wine's GdipDrawCurve implementation.
Thanks for taking a look, Andrew
Hi Andrew,
Test crashes on my box:
graphics.c:108: Test marked todo: Expected 00000000, got 00000007 wine: Unhandled page fault on write access to 0x00000000 at address 0x6039a113 (thread 0009), starting debugger... Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x6039a113). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:6039a113 ESP:0032fc50 EBP:0032fcc8 EFLAGS:00010202( R- -- I - - - ) EAX:00000000 EBX:603be1b4 ECX:41a00000 EDX:00000000 ESI:42200000 EDI:00000000 Stack dump: 0x0032fc50: 00000000 00000000 42200000 41a00000 0x0032fc60: 3e99999a 0032fc9c 0032fc94 60366806 0x0032fc70: 00000578 00000002 7b82c261 7b881f95 0x0032fc80: 00000000 00000002 0032fcc8 00124548 0x0032fc90: 00000578 40c00000 6033ab2d 41400000 0x0032fca0: 6036ed54 fffffffb 6033ab39 00000000 Backtrace: =>0 0x6039a113 GdipDrawCurve2+0x12c() in gdiplus (0x0032fcc8) 1 0x60399e8d GdipDrawCurve+0xa0() in gdiplus (0x0032fd08) 2 0x60343ca0 test_GdipDrawCurve+0x31b() in gdiplus_test (0x0032fd58) 3 0x60349969 func_graphics+0x69() in gdiplus_test (0x0032fd98) 4 0x603670d3 run_test+0x9f() in gdiplus_test (0x0032fdf8) 5 0x60367409 main+0x204() in gdiplus_test (0x0032fea8) 6 0x6036748e __wine_spec_exe_entry+0x6a() in gdiplus_test (0x0032fee8) 7 0x7b87dada start_process+0x158() in kernel32 (0x0032ffe8) 8 0x6002b997 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0x6039a113 GdipDrawCurve2+0x12c in gdiplus: movl %edx,0x0(%eax)
Not sure if that was the reason for not being committed though as the tests could run fine on AJ's magic box of course.