Hi,
On Fri, Jan 21, 2005 at 04:54:29PM +0900, Mike McCormack wrote:
ChangeLog:
- fix the DEVELOPER-HINTS file to reflect how things are really done
Did I miss something?
FIXME("(%x,%p,%d): stub\n", hdc, p, count);
- BOOL WINAPI PolyBezierTo(HDC hdc, const POINT *p, DWORD count)
- {
/* tell the user they've got a substandard implementation */FIXME("%p %p %ld\n", hdc, p, count);
This is a step backwards IMHO. It doesn't tell squat: the user doesn't know that this is a stub ("FIXME" what??), and he doesn't know that these are supposed to be the function parameters either (it could be any other variable debug printout, too - it's indistinguishable).
To developers, such a printout might make sense if it's known to be the standard format (and I'd say it isn't!), but to people that aren't fiddling with Wine on a daily basis it will mean less than the previous form.
OTOH, since "stub" is a somewhat nebulous word, too (to non-developers), it probably makes sense to leave it out (a FIXME does indicate a shortcoming after all, so such a non-specific output string makes it very likely that it's the whole function that is broken), but at least keep the braces that indicate function parameters.
But OTOH, since "... stub" has been in use for ages, its meaning is probably common knowledge amoung many older Wine users, and it's only an extra 6 or 7 characters anyway, so I'd still leave it in.
Greetings,
Andreas Mohr