On 7 September 2010 11:23, Alexandre Julliard julliard@winehq.org wrote:
Nothing says that winediag messages have to be ERR. If it's not an important failure that all users have to see, it can be a WARN or a TRACE. The hypothetical diagnostic GUI tool can then display those differently.
Things like not using direct rendering, or using a software renderer indicate a badly configured system most of the time, but aren't necessarily wrong or fatal. In that sense winediag messages would always be WARNs, because real errors or FIXMEs would go to the regular debug channels anyway. But then no regular user is going to see them unless they use the non-existent GUI. I think ERR should be reserved for real errors, so that e.g. triggering ERRs in the tests would be equivalent to introducing failures. Most of the time that's already true, but there are places that use ERR for things like invalid values passed by the application, that really don't deserve more than a WARN.