On 4/23/2010 20:30, André Hentschel wrote:
Juan Lang schrieb:
My point of view is that its not an error on windows, with this patch it passes in windows and gets a todo_wine, which it actually is (like you say).
Any test that allows all possibilities, as your patch does on Windows, is worthless. That implies that it should be investigated, and, if it's truly a meaningless test, then remove it. --Juan
It still has two benefits applying the patch: it states its a todo on wine and it documents the old behavior of windows as broken. I also see your point, just to be clear. Its just another possibility.
It's not the point of a test actually. If it different pidl is returned on Vista+ while parsing from desktop we need to figure out what pidl is returned and still test for equality. Having it not equal makes the rest of a test function useless.