On Sun, Aug 30, 2015 at 11:04 PM, Matt Durgavich mattdurgavich@gmail.com wrote:
Fixes some tests and also bug 32910
From 6b34d1b9f6cfa491a26b9c36e395c3b180b5ceea Mon Sep 17 00:00:00 2001 From: Matt matt@wymzee.com Date: Thu, 27 Aug 2015 23:43:59 -0400 Subject: [PATCH] WS2_32: Proper WSACleanup implementation using wineserver help
I see the patch is pending and I can think of a few new issues. First two minor issues that are not related which are the DLL name in uppercase in the email subject and the patch has 5 whitespace issues (whitespace after the end of a line).
The main issue is that it does not seem to work as we expect it does. And that is proved by the need of adding those new todo lines in the send() and closesocket() calls. For example in the closesocket call:
2977 fd = get_sock_fd(s, FILE_READ_DATA, NULL); 2978 if (fd >= 0) 2979 { ...
Despite being closed in the server the get_sock_fd still succeeds in the DLL returning a no longer valid handle. It looks like some out of sync problem with the ntdll cache.
Need someone else to help with that because I have no idea how to improve the patch.
Best wishes, Bruno