Re: [PATCH 1/3] kernelbase: Return FALSE in ContinueDebugEvent if status is unknown.

[Jacek Caban]

Hi Rémi,

On 31.01.2020 16:32, Rémi Bernon wrote:
> diff --git a/dlls/kernelbase/debug.c b/dlls/kernelbase/debug.c
> index 53b95aa6dda..d99309377f0 100644
> --- a/dlls/kernelbase/debug.c
> +++ b/dlls/kernelbase/debug.c
> @@ -70,6 +70,13 @@ BOOL WINAPI DECLSPEC_HOTPATCH CheckRemoteDebuggerPresent( HANDLE process, BOOL *
>   BOOL WINAPI DECLSPEC_HOTPATCH ContinueDebugEvent( DWORD pid, DWORD tid, DWORD status )
>   {
>       BOOL ret;
> -
> - if (status != DBG_EXCEPTION_NOT_HANDLED && status != DBG_CONTINUE)
> - {
> -
>    FIXME("Unknown status %x\n", status);
> -
>    return FALSE;
> - }

It's not a big deal because it's FIXME anyway, but since you're at this 
and add test anyway, we should probably set last error in this case. I 
would also consider validating that on server side.

Thanks,

Jacek