On 03/18/2010 05:03 PM, Piotr Caban wrote:
Hi,
If it's acceptable to get something else besides S_OK you should change the ok() and add a broken() (still bail out of course).
It's not acceptable to get anything else than S_OK here. I thought skip should be used to inform that not all tests are being executed.
If it's not acceptable you should do something like:
ok(hres == S_OK || broken(hres != S_OK), /* Platform where this happens */ "got %08x\n", hres); if(hres != S_OK) { skip("Skipping some tests\n"); return; }
A skip() usually means that something valid happened and we need to bail out.
Should I just return from the function without invoking skip?
A broken() would not be reported as such, a skip would at least give us some information. If the skip() is only going to happen on Windows you should use win_skip(), although in this particular case the broken() already makes sure Wine won't regress.
The end result should 'always' be that we have zero failures on all platforms.