On Thu, Mar 11, 2021 at 12:52 PM Henri Verbeet hverbeet@gmail.com wrote:
On Wed, 10 Mar 2021 at 20:50, Matteo Bruni mbruni@codeweavers.com wrote:
-void wined3d_ffp_get_vs_settings(const struct wined3d_context *context,
const struct wined3d_state *state, struct wined3d_ffp_vs_settings *settings)+void wined3d_ffp_get_vs_settings(const struct wined3d_stream_info *si,
const struct wined3d_d3d_info *d3d_info, const struct wined3d_state *state,struct wined3d_ffp_vs_settings *settings){ enum wined3d_material_color_source diffuse_source, emissive_source, ambient_source, specular_source;
- const struct wined3d_stream_info *si = &context->stream_info;
- const struct wined3d_d3d_info *d3d_info = context->d3d_info; unsigned int coord_idx, i;
I suppose that's fine, but I don't think it's quite obvious why we care, or why it's an improvement.
It doesn't matter anymore. I originally wrote this patch before the struct wined3d_context -> struct wined3d_context{_gl,_vk} split, as part of an effort to get rid of accesses to GL-specific stuff from wined3d FFP and shader key generation functions. That's now moot I think, I can throw those patches away.