On December 22, 2004 06:47 am, Alexandre Julliard wrote:
Bill Medland billmedland@mercuryspeed.com writes:
My comments are probably not clear enough. That function isn't asking if the error code is a valid error code (which is relevant to FormatMessage). Actually !acceptable_rpc_code is the list of error codes for which FormatMessage will return a valid string but that is not the string that DceErrorInqText returns; it returns the "not a valid rpc code" message. I'll reword the comments and rename the function.
I can't imagine a case where an app would depend on getting a generic error message instead of a detailed one; it seems to me that if FormatMessage returns something meaningful we should use it.
Oh. I thought we wanted to do the same as Windows does!!!
Don't ask me why but for some error codes (as detailed in the patch), even though FormatMessage can return a perfectly reasonable string, DceErrorInqText doesn't return it. E.g. 7050, 7052 and 7053 but not 7051.