Re: [PATCH 12/12] d3d10/tests: Add test_effect_constant_buffer_type test.

[Henri Verbeet]

2009/9/28 Rico Schüller :
> - ID3D10Effect* effect;

I'd prefer it if that was written as "ID3D10Effect *effect;"
> - ok(SUCCEEDED(hr), "ID3D10EffectType::GetDesc failed!\n");

Please print the actual error code as well.
> - ok(type_desc.Elements == 0, "Elements is %i, expected 0\n", type_desc.Elements);
> - ok(type_desc.Members == 2, "Members is %i, expected 2\n", type_desc.Members);
> - ok(type_desc.Rows == 0, "Rows is %i, expected 0\n", type_desc.Rows);
> - ok(type_desc.Columns == 0, "Columns is %i, expected 0\n", type_desc.Columns);

These are unsigned variables.
> - string = type->lpVtbl->GetMemberName(type, 0);
> - ok(strcmp(string, "f1") == 0, "GetMemberName(0) is "%s", expected "f1"\n", string);

You should probably use wine_dbgstr_a() for this.