On 9/7/16 9:05 PM, Alexandre Julliard wrote:
Aric Stewart aric@codeweavers.com writes:
On 9/7/16 8:14 PM, Alexandre Julliard wrote:
Aric Stewart aric@codeweavers.com writes:
On 9/7/16 5:08 AM, Sebastian Lackner wrote:
Wouldn't it be better to return an error such that IoCreateDriver() fails?
No I personally don't think so. We are successfully loading just disabled or not doing anything.
How is this useful? And why do you need a disable option?
It mostly comes from when the hidraw bus and linux event bus where separate drivers. Where there would be a real reason to want to be able to disable one or the other.
There could be future cases as well where multiple drivers are loaded in the base winebus.sys and a user would want to have granularity in their ability to turn individual ones on and off.
If that ever becomes needed, I'd suggest to then split the drivers so that they can be controlled individually through the standard service interface. It doesn't seem necessary for the first version though.
ok v6 patches for the 2 parts that changed sent to remove disabling whole busses
-aric