On Tue, 21 Oct 2008, Vincent Povirk wrote:
Yep.
It's still broken though; the string I allocated is too small (strlen excludes the null terminator), and that will be a problem if cmdline ends in a backslash.
Also it would be nice to avoid the HEAP_ZERO_MEMORY if we are going to overwrite most of these zeroes anyway. I didn't really look at the code though.