-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi Alistair,
Since you have to resend it anyway, I'll point out some things you missed:
Am 2014-05-16 11:55, schrieb Alistair Leslie-Hughes:
+extern HRESULT DPNET_CreateDirectPlay8LobbyClient(IClassFactory *iface, IUnknown *pUnkOuter, REFIID riid, void **ppobj) DECLSPEC_HIDDEN;
ppobj, pUnkOuter. I guess "riid" qualifies as hungarian notation as well, "iid" would be a better name.
+static HRESULT WINAPI lobbyclient_GetConnectionSettings(IDirectPlay8LobbyClient *iface, DPNHANDLE connection, DPL_CONNECTION_SETTINGS *sessioninfo, DWORD *infosize, DWORD flags) +{
- IDirectPlay8LobbyClientImpl *This = impl_from_IDirectPlay8LobbyClient(iface);
- FIXME("(%p)->(%d %p %p %x)\n", This, connection, sessioninfo, infosize, flags);
DPNHANDLE is a DWORD, so you should use %u. This affects the other functions as well.
You may want to use 0x%0x, or %#x instead of %x to make it obvious that a value in the logs is a hex value. This is purely a matter of taste and I'll leave it up to you - just pointing out the options.
+HRESULT DPNET_CreateDirectPlay8LobbyClient(IClassFactory *iface, IUnknown *pUnkOuter, REFIID riid, void **obj)
Same as above.
- client = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirectPlay8LobbyClientImpl));
- if (!client) {
*obj = NULL;return E_OUTOFMEMORY;- }
} placement.
Stefan