2012/12/4 Alexandre Julliard julliard@winehq.org:
Alex Henrie alexhenrie24@gmail.com writes:
My implementation is modeled after Windows XP (Wine's default target Windows version), which encodes and decodes arbitrary character sequences without normalization. I saw that my submission has already been marked "rejected"--was this why?
It was rejected because you still haven't addressed any of the issues I mentioned in previous reviews. It doesn't look like this is going anywhere.
Well, I went back through the archives and compiled the feedback you've given:
1. Don't use Katayama Hirofumi's code. http://www.winehq.org/pipermail/wine-devel/2012-May/095451.html
2. Don't use iconv. http://www.winehq.org/pipermail/wine-devel/2012-May/095468.html
3. Put the code in libwine. 4. Don't use malloc. 5. Add tests for buffer overflow. 6. Add tests for partial sequences. http://www.winehq.org/pipermail/wine-devel/2012-July/096531.html
7. Add tests for srclen < -1. http://www.winehq.org/pipermail/wine-devel/2012-August/096867.html
8. Add more tests. 9. Split up the patch. http://www.winehq.org/pipermail/wine-devel/2012-August/096872.html
10. Add tests for srclen > 0. http://www.winehq.org/pipermail/wine-devel/2012-September/096901.html
Far from not addressing any of these issues, I feel that I have addressed all of them. More importantly, my implementation is correct; it matches Windows XP exactly. (I'd be happy to be proven wrong if anyone can show me a case where this is not so.) If there is another issue which I have not addressed, it's because it has not been articulated to me. I get the impression that you have something in particular that you're looking for, but I can't tell what it is.
I do want to see this resolved. It would be a pity if Mac and Linux users miss out because we couldn't come to an agreement...
-Alex