Am Monday 14 September 2009 17:28:13 schrieb Joerg-Cyril.Hoehle@t-systems.com:
Hi,
the argument for including this code is based on symmetry: Every place in the Wine source tree (incl. ddraw, d3d9, wined3d) that handles L6V5U5 also handles X8L8V8U8 -- except for these two places. So I closed the gap.
This fixes err:ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 19 Please see bug #16559 for further discussion.
Being based on the symmetry argument means this patch is completely independent on possible missing conversions between D3DFMT and WINED3DFMT codes somewhere in Wine. I would not eliminate that possibility. The above error message that used to mention Pixelformats 62/63/64 nowadays mentions 19/64/69/70.
Regards, Jörg Höhle
The patch seems ok to me