Dan Kegel wrote:
That said, it's important when fixing Valgrind errors to really understand the code you're changing, lest you paper over a bug with another bug, or make things worse.
*cough* Debian and OpenSSL *cough* ;)
On the other hand, you shouldn't have to be completely intimately familiar with it like the original author was. It's a real problem if our code can't be read by a reasonably skilled hacker and fixed properly when Valgrind starts spewing warnings.
Thanks, Scott Ritchie