Re: [PATCH v2 2/5] winegstreamer: Check for failure from gst_element_set_state() instead of counting pads.

[Andrew Eikum]

Signed-off-by: Andrew Eikum

On Thu, Feb 22, 2018 at 09:06:14AM -0600, Zebediah Figura wrote:
> Especially since pads might be exposed before failure is reported.
> Signed-off-by: Zebediah Figura
>
> dlls/winegstreamer/gstdemux.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c
> index b48648c..b4c29db 100644
> --- a/dlls/winegstreamer/gstdemux.c
> +++ b/dlls/winegstreamer/gstdemux.c
> @@ -1160,11 +1160,11 @@ static HRESULT GST_Connect(GSTInPin *pPin, IPin *pConnectPin, ALLOCATOR_PROPERTI
>      ResetEvent(This->event);
>      gst_element_set_state(This->container, GST_STATE_PLAYING);
>      WaitForSingleObject(This->event, -1);
> - gst_element_get_state(This->container, NULL, NULL, -1);
> - ret = gst_element_get_state(This->container, NULL, NULL, -1);
> - if (!This->cStreams)
> - if (ret == GST_STATE_CHANGE_FAILURE)
> {
> -
>    FIXME("GStreamer could not find any streams\n");
> -
>    ERR("GStreamer failed to play stream\n");
>    return E_FAIL;
> }
>
> -- 
> 2.7.4