On Wed, May 24, 2017 at 9:35 AM, Stefan Dösinger stefan@codeweavers.com wrote:
Am 24.05.2017 um 14:26 schrieb Hans Leidekker hans@codeweavers.com:
Why not call ConvertInterfaceNameToLuidA and then ConvertInterfaceLuidToIndex?
Maybe I am missing something, but this looks like an even more elaborate way to implement a function that has a 1:1 match in the native library. ConvertInterfaceNameToLuidA calls getInterfaceIndexByName to do its work.
Unless I am missing something and we’re doing an elaborate interface number reordering that I can’t find in the code…
I believe iphlpapi is split in different source files to try separating the OS (ifenum.c/ifstats.c) code to the unix->windows conversion code (iphlpapi_main.c). That was the idea to reuse the other function from ifenum, if that is not what the file division was meant to mean then your patch is certainly fine ;-)