Re: [1/2] shell32: Check IsWow64Process() before calling Wow64 functions.

[Olivier F. R. Dierick]

Le jeudi 21 avril 2016 à 16:40 +0900, Alexandre Julliard a écrit :
> "Olivier F. R. Dierick"  writes:
> > I find forcing ERROR_SUCCESS in SHFileOperation() a brute and lazy way
> > to fix things. It may hide other errors. Fixing the internal code itself
> > may avoid bugs in other functions and is the way to go in my opinion.
>
> If the application depends on this, setting it explicitly is better than
> depending on side effects of internal code paths.

Ok, the patch does not fix bug 36838. I'll follow your recommandation
and make another one.

Still, I found code that generates errors for no purpose on 32 bit wine
and made a patch to fix it, avoiding possible error leaks and side
effects. Will it be considered?